Improve openentelemetry-auto-laravel test definitions for Eloquent hooks. #394
+196
−164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChrisLightfootWild
approved these changes
Jun 18, 2025
src/Instrumentation/Laravel/tests/Integration/Database/Eloquent/ModelTest.php
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #394 +/- ##
============================================
- Coverage 83.87% 83.42% -0.46%
- Complexity 1726 1949 +223
============================================
Files 114 142 +28
Lines 7293 8143 +850
============================================
+ Hits 6117 6793 +676
- Misses 1176 1350 +174 Flags with carried forward coverage won't be shown. Click here to find out more. see 29 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
Review reflected, and add missing test case for delete hook. (I forgotten) |
ChrisLightfootWild
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this review, I try to split the test cases related to Database\Eloquent\Model Hooks to a smaller dependency and simple test cases.
(Also added test cases for hooks that were not tested.)